Closed bauman closed 3 years ago
Bauman,
The idea of making the hashes configurable is sound. We will not accept the pull request as is, as there are a few issues we’d like addressed:
Lastly, if you’d like your name or organization in the copyright notice, please add that or we’ll assume you’d like to remain out of copyright notice for this file.
This allows a large degree of flexibility by the user. To remain backwards compatible, could you make sha1 on by default as well? Would you turn ssdeep on by default also, put a try/catch around ssdeep so that ssdeep remains optional (no errors due to lack of ssdeep).
We appreciate the improvements you have provided and are willing to accept this pull request when the default matches what occurred before (ssdeep hashing occurs, if ssdeep module is available).
this module was poorly written. Must have been an off day for the author.
See #4
Still needs hmac