search

lmco / laikaboss

Laika BOSS: Object Scanning System
Apache License 2.0
739 stars 156 forks source link

fix for issue #48 and logging fix #72

Open JMPercival opened 7 years ago

ewalkup commented 6 years ago

@marnao A new commit has been added that fixes the non-string child object bug (it caused the worker to crash, an earlier pull was a partial fix for this). I see that this request hasn't been active - are there any other changes we need to make to JMPercival's work?

ewalkup commented 6 years ago

@marnao Checking in again - these fixes have worked long-term for us, this should be ready to integrate. Let me know if it requires more changes.

marnao commented 6 years ago

I am rolling these into our baseline for testing. I will merge as soon as I verify.

ewalkup commented 6 years ago

@marnao Just checking in again. We have other stuff we want to submit but we don't want more stuff in this pull request probably.

ewalkup commented 6 years ago

@marnao Pushed a fix - just moved that one line around. We have the same fix running in our environment and haven't seen it cause any errors (though we don't get unicode often).