lmco / laikaboss

Laika BOSS: Object Scanning System
Apache License 2.0
732 stars 155 forks source link

Upgrade pefile - Rich Headers Not Being Extracted #76

Open ewalkup opened 5 years ago

ewalkup commented 5 years ago

This isn't in the Laikaboss code, but the installation instructions list a specific, old version of pefile to use.

Under this version, rich headers are not extracted by pefile, and never make it into metadata. Instead, you just see an empty dictionary under the "Rich Header" label.

This can be fixed by upgrading to the latest version (v2018.8.8 as of this posting) - we haven't had any compatibility issues upgrading. Note: We saw this bug under pefile v2016.3.4, which is even newer than the one listed in the instructions. I'm not sure at what point it was fixed, but sometime in the last two years...