search

lmfit / asteval

minimalistic evaluator of python expression using ast module
https://lmfit.github.io/asteval
MIT License
183 stars 41 forks source link

MAINT: remove deprecated aliases when using NumPy v1.20.0 #84

Closed reneeotten closed 3 years ago

reneeotten commented 3 years ago

This PR removes deprecated functions/aliases when using NumPy v1.20.0 ; see the release notes for more information.

Quite possibly there is a more elegant way of doing this, but in my testing for lmfit it works as expected.

codecov-io commented 3 years ago

Codecov Report

Merging #84 (b19818a) into master (414211c) will decrease coverage by 0.09%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   91.90%   91.81%   -0.10%     
==========================================
  Files           4        4              
  Lines         741      745       +4     
==========================================
+ Hits          681      684       +3     
- Misses         60       61       +1
Impacted Files Coverage Δ
asteval/astutils.py 86.98% <75.00%> (-0.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60979bc...b19818a. Read the comment docs.

newville commented 3 years ago

@reneeotten thanks! I think this is OK. Since we don't explicitly document what we import from numpy, and since these are all sort of obscure (right to be deprecated), we could just remove these. I'll merge as is, and will hope that this gets removed eventually as "obviously no longer needed".