search

lmhale99 / atomman

Atomistic Manipulation Toolkit
Other
34 stars 40 forks source link

Version 1.3.2 not working in Python 3.6 #15

Closed HumHongeKamyaab closed 4 years ago

HumHongeKamyaab commented 4 years ago

from importlib import resources not working in python 3.6 importlib.resources object is new in version 3.7 check out https://docs.python.org/3/library/importlib.html#module-importlib.resources

Due to above reason atomman version 1.3.2 can't be used in python versions < 3.7

lmhale99 commented 4 years ago

If 3.6 support is still needed, I can add a try-except around the import with the old way as the except.

Otherwise, I can just remove the listing for 3.6 from the setup file...

HumHongeKamyaab commented 4 years ago

Ubuntu 18.04 LTS(bionic) is still using Python 3.6. I think latest version of atomman should atleast support python 3.5.

lmhale99 commented 4 years ago

I just updated the root init file with the correction and pushed it to this repository. I'll close this issue when I get around to releasing a version 1.3.3.

When I removed Python 2 support I also started using f-strings in a number of places due to their convenience. As they were introduced in Python 3.6, ensuring 3.5 compatibility would require combing through all the code and making things less readable.

lmhale99 commented 4 years ago

This should be fixed now