lmika / goseq

A command line tool to generate sequence diagrams
https://goseq.lmika.dev
MIT License
205 stars 26 forks source link

Loop and Alt use the full width instead of only covering the leftmost to rightmost inner columns. #11

Closed TheMightyGit closed 4 years ago

TheMightyGit commented 4 years ago

If I have 5 columns and a loop around 2 of them the outer box of the loop is the full width of the diagram. I expected it to only cover the leftmost to rightmost of the inner referenced columns. For a diagram with many loops it makes it visually very noisy when all boxes are full width.

One->Two:

loop: loop1
  Two->Three:
end

Three->Four:
Four->Five:

In the above code I would expect the loop to only encompass Two and Three. Instead it is the full width...

Screenshot 2020-10-08 at 17 28 14

(Although I'm queueing up a bunch of issues I may take a look at them myself - I just wanted to be able to track and prioritise them)

lmika commented 4 years ago

Yep, this is something that can improve the quality of the diagrams. Thanks for taking a look at it, @TheMightyGit.