search

lmiller1990 / design-patterns-for-vuejs-source-code

Soure code for my book "Design Patterns for Vue.js": https://lachlan-miller.me/design-patterns-for-vuejs
126 stars 28 forks source link

Improve suggestions about Chapter4 #5

Closed kazuooooo closed 1 year ago

kazuooooo commented 2 years ago

Hi, thank you for writing great book. I've read chapter4, and I noticed few improvements, so I've created PR.

  1. Test case throws and error when count isNaN test arg with string not NaN.( 7d5234546785a796e747bbfcfa10a41da408c73f)
  2. submitValidator only test count is not string and not Nan. I think the function should check count is number. For example pass array to arg is passed. (29a652818dca1c61e6b0095fb0033515e396af27)

It's just suggestion, No need to merge Thanks.

lmiller1990 commented 2 years ago

Hey, thanks for checking my book out! I'm really glad you enjoyed it.

I hope to do a major update soon - I'll definitely include these suggestions.

kazuooooo commented 2 years ago

@lmiller1990 Thank you!

lmiller1990 commented 1 year ago

Thanks - sorry for the slow reply!

I'll fix this as part of: https://github.com/lmiller1990/design-patterns-for-vuejs-source-code/issues/8

lmiller1990 commented 1 year ago

See last comment in #8