END-KERNEL isn't sufficient

[phmarek]

The current implementation of END-KERNEL isn't sufficient - the threads are not necessarily gone when that function returns.

I'm doing something akin to

  (let (...
        (lparallel:*kernel* (lparallel:make-kernel 4)))
    (format t "Loading...~%")
    (lparallel:pmap nil 
                    (lambda (file)
                      (import-file ...))
                    ...)
    (lparallel:end-kernel :wait t))
  (save-lisp-and-die ...)

but that (sometimes) breaks with

debugger invoked on a SB-IMPL::SAVE-WITH-MULTIPLE-THREADS-ERROR in thread
#<THREAD tid=3161136 "main thread" RUNNING {1003848003}>:
  Cannot save core with multiple threads running.

  Interactive thread (of current session):
    #<THREAD tid=3161136 "main thread" RUNNING {1003848003}>

  Other thread:
    #<THREAD "lparallel" FINISHED values: NIL {1069E88B23}>
See also:
  The SBCL Manual, Node "Saving a Core Image"

What does seem to help is to use

    (map 'nil
         #'sb-thread:join-thread
         (lparallel:end-kernel :wait t))))

but I guess that should be done in lparallel proper?!

Thanks!

[luismbo]

Maybe raise the issue at and/or send a pull request to https://github.com/sharplispers/lparallel

[phmarek]

Thanks, will do! This repo is listed on https://lparallel.org/download/, that's how I got here.