lmjohns3 / theanets

Neural network toolkit for Python
http://theanets.rtfd.org
MIT License
328 stars 73 forks source link

HF trainer's cost set wrong value. #33

Closed reyoung closed 10 years ago

reyoung commented 10 years ago

The code here set hf trainer to all monitor value of network, which include accuracy. The hf trainer will never find a new best value because the cost, which include accuracy, will always get larger if the network is trained well.

The accuracy should be not passed to hf trainer.

lmjohns3 commented 10 years ago

I believe the HF trainer only uses the first quantity in the monitors list to evaluate training progress; the rest are just there to provide more information during training. (See https://github.com/boulanni/theano-hf/blob/master/hf.py#L268 for the code.)

reyoung commented 10 years ago

You're right, my mistake.