search

lml / commontator

A Rails engine for comments
MIT License
353 stars 99 forks source link

Ruby 2.7 Deprecation Warnings #174

Closed alaarab closed 3 years ago

alaarab commented 4 years ago

When running Rails 6.0.3.1 and Ruby 2.7.1 I get the following on rails s:

/home/ala/.rvm/gems/ruby-2.7.1/gems/commontator-6.3.0/lib/commontator/acts_as_commontator.rb:22: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

/home/ala/.rvm/gems/ruby-2.7.1/gems/commontator-6.3.0/lib/commontator/acts_as_commontable.rb:20: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

alaarab commented 4 years ago

It looks like this is handled in this PR: https://github.com/lml/commontator/pull/173

alaarab commented 4 years ago

@Dantemss can you please merge this PR into the official master branch?

Dantemss commented 3 years ago

Merged #173