search

lml / commontator

A Rails engine for comments
MIT License
354 stars 99 forks source link

Copying javascripts is disabled #180

Open jacobtjackson opened 4 years ago

jacobtjackson commented 4 years ago

Hi, I'm trying to use commontator with a Rails 5.2 app that uses webpacker for javascript deployment. I tried importing the necessary javascripts going off of the readme, but didn't have much success. I then noticed that you can copy most of the gem into your project using rails commontator:copy:<item_to_copy/>. This worked great for the stylesheets, but it doesn't seem to have an option for copying the javascript files; when I run rails --tasks the list of commontator-related tasks looks like this: 

rails commontator:copy                   # Copy assets, views, mailers, helpers, controllers and models from commontator to application
rails commontator:copy:controllers       # Copy controllers from commontator to application
rails commontator:copy:helpers           # Copy helpers from commontator to application
rails commontator:copy:images            # Copy images from commontator to application
rails commontator:copy:locales           # Copy locales from commontator to application
rails commontator:copy:mailers           # Copy mailers from commontator to application
rails commontator:copy:models            # Copy models from commontator to application
rails commontator:copy:stylesheets       # Copy stylesheets from commontator to application
rails commontator:copy:views             # Copy views from commontator to application
rails commontator:install                # Copy initializers and migrations from commontator to application
rails commontator:install:initializers   # Copy initializers from commontator to application
rails commontator:install:migrations     # Copy migrations from commontator to application

Is there another way I can easily copy the Javascript files without having to do it manually?

alaarab commented 4 years ago

what about rake commontator:copy:javascripts (as per the documentation)

jacobtjackson commented 4 years ago

@alaarab Right, I tried that and got an error that basically said that command isn't defined (I'm paraphrasing here because I don't remember exactly what the error was, but that error was what prompted me to check the list of available tasks in the first place).

If you look at the file where the tasks are defined you will see that javascripts is no longer one of the available tasks so it must have been taken out at some point? Either way the documentation should be updated at the very least.

inspire22 commented 2 years ago

Did you end up figuring out how to copy out the javascripts? Looking into using this with import maps and rails 7 and figure it might need some tweaks like this.

jacobtjackson commented 2 years ago

Did you end up figuring out how to copy out the javascripts? Looking into using this with import maps and rails 7 and figure it might need some tweaks like this.

I didn't, I ended up giving up and using "acts_as_commentable" instead