lml/ost#340: Add exercise content(question) to the feedback page.

[navilan]

WIP.

• Add exercise content (question only) to the feedback page as a collapsible section.
• Remove trailing whitespaces.
• Remote trailing whitespaces in show.html.erb as well.

Notes:

• Free text/drawing provided by the student is not shown.
• The other options in multiple selection are not shown.
• The sidebar nav has misleading text ("Show" instead of "Go to")
• Collapsible sections could use simple CSS instead of inline JS.
• By introducing a section heading the header hierarchy is disrupted.

[jpslav]

Note that while we are good with automated tests on some of our products, this is not one of them :-) So ignore the travis build errors.

[jpslav]

In general, I'd say let's not avoid trailing whitespace as it makes PRs more difficult to review (lots of trivial highlighted changes on github obscure the important changes from the PR)

[jpslav]

Re your comment "Free text/drawing provided by the student is not shown." I think it would be reasonable to show a "Your Free Response" section on this feedback page -- would make it a more useful study resource for students. @kjdav do you agree?

Related code is here, though not all of it is needed (don't need follow up answers or ability to add new free responses).

This new section could be collapsed too so we don't make the page too busy (want them to definitely see what the right answer was -- their answer isn't as critical).

[jpslav]

Re:

1. The other options in multiple selection are not shown.
2. The sidebar nav has misleading text ("Show" instead of "Go to")
3. Collapsible sections could use simple CSS instead of inline JS.

(1) -- that's ok, don't need to show the other distractors (2) -- some UX people are going to do a pass through the site later this summer and they'll pick new language, tho I agree "Go to" will be better. (3) -- indeed, let's fix later here but definitely use that approach in other sites going forward.

[jpslav]

@lakshmivyas after you make changes per the comments and I take a peek, we'll have @kjdav give this PR a whirl and provide feedback from a usability perspective. thanks!

[kjdav]

agree that showing free response on FB page is useful -- note we already show this on the question status page. i do think it makes more sense to show it on the feedback page.

@jpslav, why don't you think we need to show the MC distractors on this page? i think it'd be useful for students to see that. also OST feedback refers to them, i.e., "the correct answer is (c)" and "you chose (b)"

On Mon, May 19, 2014 at 12:36 PM, JP Slavinsky notifications@github.comwrote:

@lakshmivyas https://github.com/lakshmivyas after you make changes per the comments and I take a peek, we'll have @kjdavhttps://github.com/kjdavgive this PR a whirl and provide feedback from a usability perspective. thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/lml/ost/pull/343#issuecomment-43526956 .

[jpslav]

@kjdav I worry about cluttering up this page too much. In the future when we have a snazzy client-side responsive app, we can provide links to much more information while still making the page concentrate on the exercise feedback by default. Will take some thought from our pending UX team.

[navilan]

@jpslav:

1. Trailing whitespace: I have my editor remove them automatically on save. I will turn it off for this project.
2. Multiple choices: My current plan is to reuse the assignment_exercise partial here. Over there I have the choices as a collapsed section. If they are still occupying too much space, we can get rid of them.

Will make the other changes. For now I am closing this pull request. I will open a new one that has all of these changes to avoid merge conflicts.

[jpslav]

Nothing has been merged yet so you can just push again if u want

On May 20, 2014, at 2:22 AM, Lakshmi notifications@github.com wrote:

@jpslav:

Trailing whitespace: I have my editor remove them automatically on save. I will turn it off for this project. Multiple choices: My current plan is to reuse the assignment_exercise partial here. Over there I have the choices as a collapsed section. If they are still occupying too much space, we can get rid of them. Will make the other changes. For now I am closing this pull request. I will open a new one that has all of these changes to avoid merge conflicts.

— Reply to this email directly or view it on GitHub.

[navilan]

@jpslav - Mainly closed this as there are dependencies. (exercise in feedback -> assignment exercise -> rbenv). Keeping them separate makes it more complicated than it needs to be.

[jpslav]

yep sounds good.