Closed navilan closed 10 years ago
@jpslav / @kjdav - I think this is fairly complete. I am not sure if the multiple cohorts are aggregated as I am still having issues in configuring the DB.
@jpslav - I am not too confident of the model code in the last commit. Can you please let me know if I have screwed up in a big way? :)
@jpslav / @kjdav - Thanks to Kim's dev db - I can see that cohorts don't work as expected yet. Will fix.
@jpslav / @kjdav - multiple cohort support is in there now. I am not too happy with the styles. Will work on polishing the styles and fixing any comments you have tomorrow.
Thanks so much @jpslav / @Dantemss. Great feedback. Will get these addressed now.
@Dantemss: The last commit has the new query. There is a harmless but nevertheless annoying issue where joins are repeated. Other than that seems to be a good solution. Thanks so much.
@jpslav : I added prev/next methods to acts as numberable - please let me know if it looks good.
@kjdav : Kim, at this point, I think that functionally the page is complete - whats remaining from my rather limited perspective is polish (styling, testing, optimization). If you can look through it one more time and let me know your comments, I can address them as a final pass before this gets merged.
@jpslav / @kjdav / @Dantemss - I think the PR is ready for final review / testing and merge.
Thanks so much for all your help. Much appreciated.
this looks good from my perspective, both the changes to the branch and also the result when i merged into my local master. I checked that instructor/researcher permissions are correct for these pages, that the next/prev nav goes to the correct questions, and that students can see all the new info lakshmi added. looks great.
On Thu, May 22, 2014 at 4:15 PM, Lakshmi notifications@github.com wrote:
@jpslav https://github.com/jpslav / @kjdav https://github.com/kjdav / @Dantemss https://github.com/Dantemss - I think the PR is ready for final review / testing and merge.
Thanks so much for all your help. Much appreciated.
— Reply to this email directly or view it on GitHubhttps://github.com/lml/ost/pull/348#issuecomment-43938453 .
@kjdav - Awesome :) Excited about having my first commit to the project.
@jpslav - I am waiting for this to be merged before I start the rest of the issues. I am now in deathmatch mode ;)
Thanks @lakshmivyas!
WIP. Refactored and consolidated the previous pull requests.
collapsability
params (solved with a partial layout instead.)Fix layout and styles to make the page look and feel better.(Deferred until later).Figure out if tests can and need to be added for complex bits.(Saving these for later)