Closed jan-janssen closed 4 months ago
Thanks @jan-janssen & @pkruzikova :raised_hands:
In general the changes make sense, however I would rather have a flag that defaults to read-only mode for most cases but still allows to grab the engine
for making edits and additions to the db programatically. I might be the only person who's doing that atm but wouldn't want to duplicate the function for the "dev" mode. Could you add a flag to get_engine
and get_session
to parametrize the access mode?
There seem to be some small linting errors, that should be easy to fix.
Could you add a flag to
get_engine
andget_session
to parametrize the access mode?
@lmmentel I added the flag to get_engine
and get_session
.
There seem to be some small linting errors, that should be easy to fix.
In addition I fixed the linting errors.
Thanks :+1:
Perfect, thanks a lot - @lmmentel Can you create a new release?
Yes :100:
When the
mendeleev
package is located on a Network File System (NFS) Sqlalchemy fails with an OperationalError.This is a known limitation of SQLite:
As the data in the
elements.db
file never changes, the solution is to connect to the SQLite database using read-only mode. This is implemented in this pull request.Originally reported by @pkruzikova