search

lmorabit / lofar-vlbi

GNU General Public License v3.0
16 stars 13 forks source link

Fix startmod parameter to match its description #73

Closed tikk3r closed 3 years ago

tikk3r commented 3 years ago

Running selfcal_difmap.py standalone and passing --startmod currently disables generation of a starting model. This makes it match its description so that passing --startmod enables generation of a starting model.

lmorabit commented 3 years ago

startmod = True means generate a starting model, initialised to a point source of 1 Jy. startmod = False means do NOT generate a starting model; this is the expected behaviour. It is a boolean switch that's set to what the most likely use case is supposed to be.

tikk3r commented 3 years ago

startmod = True means generate a starting model, initialised to a point source of 1 Jy. startmod = False means do NOT generate a starting model; this is the expected behaviour

That is how I interpreted its function. It just confused me as the help describes it as "Generate a starting model.", but it does the opposite of this when the switch is enabled, i.e. selfcal_difmap.py --startmod <ms> will not generate a starting model and selfcal_difmap.py <ms> will.

lmorabit commented 3 years ago

Instead of changing the functionality, which impacts the rest of the pipeline, I have changed the help description to:

"Generate a starting model from the data. Otherwise a point source of 1 Jy will be used."