search

lmorabit / lofar-vlbi

GNU General Public License v3.0
16 stars 13 forks source link

Issue: couple of typos and import errors in scripts #96

Closed ebonnassieux closed 11 months ago

ebonnassieux commented 1 year ago

Heya, just opening the issue because they're trivial fixes but recur whenever sourcing the code again:

on line 38 of bin/run_selfcal.py, "destifle" should be "destfile" find_lotss_sources.py is missing "from time import sleep" leading to an uninformative bug when it crashes after a timeout

Otherwise things more or less run out of the box reliably which is fantastic!

lmorabit commented 1 year ago

Thanks!

I've fixed run_selfcal.py, but I don't see where sleep is used in find_lotss_sources.py . I am willing to believe the fix is needed, but can you please provide a bit more information as to why?

lmorabit commented 1 year ago

@ebonnassieux waiting for further information to resolve or close this issue.

jdswinbank commented 11 months ago

I'm guessing the problem is actually here

mhardcastle commented 11 months ago

Since this looks like it might have been my code once upon a time, I've pushed a fix to what @jdswinbank pointed out... @ebonnassieux please reopen if this is not the issue.