search

lmorabit / lofar-vlbi

GNU General Public License v3.0
16 stars 13 forks source link

A couple of fixes: add quote and revised argument name #98

Open ggurkan opened 1 year ago

ggurkan commented 1 year ago

Hi, delay_sols should be saved as string in facetselfcal_config.txt and facetselcal.py expects preapplyH5_list as an argument not preapplyH5-list so the following line could be added to run_selfcal.py to fix these issues:

os.system("sed -i 's!"+delay_sols+"!"+'"'+delay_sols+'"'+"!g' facetselfcal_config.txt")
os.system("sed -i 's!preapplyH5-list!preapplyH5_list!g' facetselfcal_config.txt")

after the following line: os.system( 'sed -i "s~DELAYCAL_SOLUTIONS~{:s}~g" {:s}'.format(delay_sols, destfile))

lmorabit commented 1 year ago

Hi Gulay, at what point in the pipeline are you having this error? Is it in Split-Directions?

ggurkan commented 1 year ago

Yes, in the split-directions step and I sorted it out using the lines above.

lmorabit commented 1 year ago

Okay, thanks for pointing this out. It needs a different solution than the one you suggest, as run_selfcal.py is used by both Delay-Calibration and Split-Directions and needs to work for both. I'll work on a fix.