Course 3 - Week 2 - Lesson 3.ipynb error

lmoroney / dlaicourse

Notebooks for learning deep learning

5.66k stars 5.38k forks source link

Course 3 - Week 2 - Lesson 3.ipynb error #134

Open rbhambriiit opened 3 years ago

rbhambriiit commented 3 years ago

https://github.com/lmoroney/dlaicourse/blob/master/TensorFlow%20In%20Practice/Course%203%20-%20NLP/Course%203%20-%20Week%202%20-%20Lesson%203.ipynb

history = model.fit(train_data, epochs=num_epochs, validation_data=test_data) hits error.

fix: replace train_data with train_dataset replace test_data with test_dataset

rbhambriiit commented 3 years ago

also i see:

Epoch 10/10 391/391 [==============================] - 16s 41ms/step - loss: 0.1622 - accuracy: 0.9431 - val_loss: 0.3225 - val_accuracy: 0.8786

course video expects this to be ~60%

juan-coursera commented 3 years ago

Hi rbhambriiit,

Yes, it should be train_dataset and test_dataset. This was a typo on my part. I made a pull request #110 back in June 12th to fix this. I'm waiting for it to be merged.