search

lmoroney / dlaicourse

Notebooks for learning deep learning
5.66k stars 5.36k forks source link

One mistake in Exercise 5 - Answer.ipynb #27

Closed ZhiliangWu closed 5 years ago

ZhiliangWu commented 5 years ago

For the Exercise 5 in Course 2, there is one mistake in the split_data function. 

    ...
    training_set = shuffled_set[0:training_length]
    testing_set = shuffled_set[:testing_length]
    ...
JonathanSum commented 5 years ago

Do you think the correction should be this? testing_set = shuffled_set[training_length:len(files)] .

If so, I will pull a request and ask for a fix.

This question was proposed before: https://www.coursera.org/learn/convolutional-neural-networks-tensorflow/discussions/weeks/1/threads/qc6UgmNCEemspw46kN80NA

ZhiliangWu commented 5 years ago

Yes. Or simply testing_set = shuffled_set[training_length:]should be enough.