search

lmparppei / Beat

Beat - a simple and elegant screenwriting app for macOS
Other
175 stars 30 forks source link

1.92.2 (and onwards?) API missing get...() for setDocumentSetting() and setRaw...Setting() #87

Closed ftolsson closed 2 years ago

ftolsson commented 2 years ago

Here's hoping you've laid all the groundwork already but just forgot to include two methods in the API... ...because right now, as far as I can tell, plugins can save stuff to the document (great!) but then... well, not read them again.

I actually peaked into your latest BeatPluginParser.h to see if perhaps you'd named the corresponding methods to something else, but to me it seems as if they're not there yet. (I did find a getPropertyValue() though — for those who really know what they're doing — but I was obviously not one of them... :)

So. Keeping my fingers crossed that getDocumentSettings() and getRawDocumentSettings()are more or less done and won't take too much effort to connect to the API.

That's all!

lmparppei commented 2 years ago

This is what a quality-made enterprise software looks like.

Thank you, fixed in 1.923

ftolsson commented 2 years ago

Not to add comments to a closed issue (or, well, I guess I am) but... ...am I doing this wrong?

image
ftolsson commented 2 years ago

Oh. Wait. Because -- I am allowed to write my own settings, right...? That's what I gathered from the announcement in discord, but from the wiki I'm not so sure anymore...

But it does seem like I'm allowed to save settings though -- with this code: Beat.setDocumentSetting("documentName", documentName) I get this in the Beat file: BEAT: {"FTOutliner: documentName":"Testing" (...)

It's just that I can't seem to retrieve that saved setting again...?

lmparppei commented 2 years ago

This is what world-famous Finnish minimalist design looks like. I've now actually exposed those methods to the API.