lmrodriguezr / nonpareil

Estimate metagenomic coverage and sequence diversity
http://enve-omics.ce.gatech.edu/nonpareil/
Other
42 stars 11 forks source link

Default output prefix not very friendly #67

Closed jfy133 closed 3 weeks ago

jfy133 commented 3 weeks ago

Running

./nonpareil-3.5.2-Linux_x86_64 -s ERX5474932_ERR5766176_2.fastq.gz -T kmer -f fastq 

produces

-rw-rw-r-- 1 james james 833K Jun 28 12:39 ''$'\205\300\017\205\277''.npa'
-rw-rw-r-- 1 james james  20K Jun 28 12:39 ''$'\205\300\017\205\277''.npc'
-rw-rw-r-- 1 james james 1.9K Jun 28 12:39 ''$'\205\300\017\205\277''.npl'
-rw-rw-r-- 1 james james 1.8K Jun 28 12:39 ''$'\205\300\017\205\277''.npo'

Which is not a very Unix friendly default. I would recommend making teh default -b to be either e.g. nonpareil.npa or maybe take the file name input without the suffix fasta/fastq/fasta.gz/fastq.gz suffix

(note specifying -b works as expected) :)

lmrodriguezr commented 3 weeks ago

That's a very good suggestion! I always pass -b, but having a friendly default is much better

jfy133 commented 3 weeks ago

Either that or make -b required :), also would be a reasonable approach IMO

jfy133 commented 3 weeks ago

Works nicely, thanks :D