lmsace / academi

Academi - a responsive moodle theme developed by LMSACE
6 stars 9 forks source link

Slider on the homepage is behaving erratically #59

Open jbulies opened 2 months ago

jbulies commented 2 months ago

The slider on the homepage is behaving erratically. It does not recognize the values for autoplay or pause time. Whatever value is defined in the configuration, the slider always plays automatically and changes slides very quickly, 1 second or less for each one. I would appreciate a response to correct this situation.

pheeberoni commented 2 months ago

Hi there jbulies - I have the same issue, except sometimes the autoplay doesn't even trigger. I'd appreciate anyone who knows what might be going on!

jbulies commented 2 months ago

Hi there jbulies - I have the same issue, except sometimes the autoplay doesn't even trigger. I'd appreciate anyone who knows what might be going on!

I solved it but it is not a clean solution, when the theme is updated the changes will be lost, you must modify the following files:

/moodle/theme/academi/amd/src/homeslider.js

/moodle/theme/academi/amd/build/homeslider.min.js

In both you must change the following lines:

interval: 5000

if ($content == "undefined" && $content.length == "") {

The first is for the time the slide takes and the second avoids the animation where the title and text of the slide take a long time to appear and which really doesn't do it well.

JuaniV2002 commented 1 month ago

I'm having the same issue over here. I tried doing what @jbulies proposed, but it's no use.

I would like a "cleaner" solution for this problem.

ribenjamin commented 2 weeks ago

I'm having exactly the same issue. Sometimes it autoplays with an interval time of less than a second (which gives you a headache just looking at it) and sometimes the autoplay doesn't happen at all. It seems totally random.

The homepage slider settings switching Autoplay on or off or changing the interval time seem to have no effect.

I'm not sure how to update the js files. How do I do that?

Do you think the theme makers will fix this and update the theme with the fix?

jbulies commented 2 weeks ago

They already solved it in the latest version 4.4.1

ribenjamin commented 2 weeks ago

Hello José @jbulies

My Moodle version is 4.3.3. Will the fixed version of the theme work on Moodle 4.3.3?

If I have to update the Moodle version, will this break any other plugins already installed?

Sorry. I suspect these are real newbie questions!

Thank you! :-)

JuaniV2002 commented 2 weeks ago

Hi @ribenjamin, in order to get the latest release of academi, you have to be on Moodle 4.4 or higher.

If you have other plugins in which you are heavily dependent on, I would wait for all of them to release their updates to accommodate for Moodle 4.4. As of me, my Moodle site depends on Microsoft 365 and on OpenID plugins, which are a key part of my project.

What you can do, it's create a testing environment for your Moodle site, so that you can try the latest releases and updates of your plugins without breaking anything on your production site. I did it using docker, following these instructions.

Happy coding!