search

lmsqueezy / laravel

A package to easily integrate your Laravel application with Lemon Squeezy.
https://lemonsqueezy.com
MIT License
468 stars 47 forks source link

WIP: Feature/add discount functionality #65

Closed Diddyy closed 4 months ago

Diddyy commented 7 months ago

This is my first ever pull request to a package. Apologies in advance for anything I have gotten wrong!

This is still a WIP. My main struggle is I have never written any Pest tests so am bumbling my way through them.

This aims to add discount functionality to the package as stated on the roadmap as desired. Thought I'd try my best to kick it off instead of sitting around and expecting someone to do it for me :)

I'd appreciate ANY input or pointers or even better any commits :)

driesvints commented 7 months ago

Thanks for the PR! I'll give this a look as soon as I find the time.

Diddyy commented 7 months ago

No worries, I have contributed as much as I can and am now stuck. With 2 tests failing but I cannot figure out how to sort them.

Feel like I have managed most of the groundwork for it all though! :)

Failing Tests; it('checks if repeating duration discount remains active for specified months') it('checks if forever duration discount always remains active')

Diddyy commented 7 months ago

I'm afraid thats the best I can do now! Not sure what more to do :)

Happy for any review or help to get this merged :)