search

lmsqueezy / laravel

A package to easily integrate your Laravel application with Lemon Squeezy.
https://lemonsqueezy.com
MIT License
521 stars 51 forks source link

Fix Tests on Laravel 11 and exit codes #79

Closed heyjorgedev closed 8 months ago

heyjorgedev commented 8 months ago

This PR fixes the following issues:

  1. Exit Codes were not being properly reported to GitHub Actions due to exit() calls on a command execute from the tests
  2. Changes to TestCase to execute Laravel migrations on Laravel 11
driesvints commented 8 months ago

Thanks @heyjorgedev! Did some changes here as well.

heyjorgedev commented 8 months ago

@driesvints Ahh nice, I didn't want to do those changes to have the PR focused on the tests, but nice to know that you would have felt comfortable reviewing those changes also, will keep in mind for future PR's.

I have the feeling the listen command could be improved a bit too, not throw the ValidationException and instead output nice pretty error messages from the validation, will draft a PR for some stuff later