search

lmstudio-ai / .github

34 stars 3 forks source link

Start bumping version when changing sha256 of application files #6

Open epelc opened 6 months ago

epelc commented 6 months ago

When you update the download links without bumping version numbers/changing the url you are breaking homebrew installs.

https://github.com/Homebrew/homebrew-cask/pull/162878

Please start bumping versions when you publish hidden updates. Homebrew is a very common way to install applications on macOS.

yagil commented 6 months ago

Noted. TODO: need to find a way to handle hot-fixes better to avoid breaking homebrew.

epelc commented 6 months ago

@yagil They ended up marking this cask as skip checking the hash so this is technically no longer an issue. However it's probably a bad practice to do hotfixes without bumping version numbers so this would be nice to switch to.

How do I know if 2.9.1 from last week is good vs 2.9.1 from this week unless it's 2.9.2 or something higher.

https://github.com/Homebrew/homebrew-cask/pull/162878#issuecomment-1863342744

yagil commented 6 months ago

@epelc indeed, needs a better solution. The current practice is no good.