lmterryn / ITSMe

https://lmterryn.github.io/ITSMe/
40 stars 8 forks source link

error in stem_branch_radius_qsm #6

Open GakenouOF opened 4 weeks ago

GakenouOF commented 4 weeks ago

Hello @lmterryn,

Thank you for this wonderful packagefor easy extraction of structural metrics.

I am running the summary_qsm_metrics() function and i am getting this error

Error in stem_branch_radius_qsm(cylinder = qsm$cylinder, treedata = qsm$treedata, : unused argument (sbr_normalisation = sbr_normalisation)

i checked the stem_branch_radius_qsm function from metric_terryn_2020.R and i see that the argument is normalisation

stem_branch_radius_qsm <- function(cylinder,
                                   treedata,
                                   normalisation = "treeheight",
                                   pc = NA,
                                   dtm = NA,
                                   r = 5) {

However, in the summary_qsm_metrics() function, sbr_normalisation was used as an argument and was called in the calculation of sbr using stem_branch_radius_qsm()

sbr <- stem_branch_radius_qsm(
          cylinder = qsm$cylinder,
          treedata = qsm$treedata,
          sbr_normalisation = sbr_normalisation,
          pc = pc,
          dtm = dtm,
          r = r
        )

I suspect this might be the reason for the error and i think the same should be checked for sbl_normalisation, and sbd_normalisation

lmterryn commented 3 weeks ago

Hi Oluwaseun

How did you call the summary_qsm_metrics() function? From the error it seems something went wrong with the arguments that you give the function.

Cheers Louise


Van: Oluwaseun Gakenou @.> Verzonden: zaterdag 26 oktober 2024 18:46 Aan: lmterryn/ITSMe @.> CC: Louise Terryn @.>; Mention @.> Onderwerp: [lmterryn/ITSMe] error in stem_branch_radius_qsm (Issue #6)

Hello @lmterrynhttps://github.com/lmterryn,

Thank you for this wonderful packagefor easy extraction of structural metrics.

I am running the summary_qsm_metrics() function and i am getting this error

Error in stem_branch_radius_qsm(cylinder = qsm$cylinder, treedata = qsm$treedata, : unused argument (sbr_normalisation = sbr_normalisation)

i checked the stem_branch_radius_qsm function from metric_terryn_2020.R and i see that the argument is normalisation

stem_branch_radius_qsm <- function(cylinder, treedata, normalisation = "treeheight", pc = NA, dtm = NA, r = 5) {

However, in the summary_qsm_metrics() function, sbr_normalisation was used as an argument and was called in the calculation of sbr using stem_branch_radius_qsm()

sbr <- stem_branch_radius_qsm( cylinder = qsm$cylinder, treedata = qsm$treedata, sbr_normalisation = sbr_normalisation, pc = pc, dtm = dtm, r = r )

I suspect this might be the reason for the error and i think the same should be checked for sbl_normalisation, and sbd_normalisation

— Reply to this email directly, view it on GitHubhttps://github.com/lmterryn/ITSMe/issues/6, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APAT3O5YHPPW5OBL6PC34X3Z5PBP3AVCNFSM6AAAAABQU6POBWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYTKOJZGQYTSMA. You are receiving this because you were mentioned.Message ID: @.***>

GakenouOF commented 3 weeks ago

Hello @lmterryn ,

Yes, I called the function and I used it as explained in vignette(ITMSe). At first, when I ran it with the default settings, I got the error. Then I ran it again with non-default settings and still got the error.