search

lmucs / cher-ami

Exclusive Content Sharing
10 stars 2 forks source link

Full Test Coverage on SearchCircles #30

Open AuthorOfTheSurf opened 9 years ago

AuthorOfTheSurf commented 9 years ago

SearchCircles (GET /circles) was recently merged into master without full test coverage implemented. The merge was done to provide the mobile and web teams with a correctly functioning endpoint to get rid of roadblocks. The endpoint has been tested by hand, which is not sustainable. The following tests have been stubbed out and should be completed.

func (s *TestSuite) TestSearchCirclesOfTargetOK(c *C) {
    // stub
}

func (s *TestSuite) TestSearchCirclesNoSpecificUserOK(c *C) {
    // stub
}

func (s *TestSuite) TestSearchCirclesBeforeWorks(c *C) {
    // stub
}

The first two are of higher priority than Before.

AuthorOfTheSurf commented 9 years ago

Most of search circles is tested. Except for the before section

func (s *TestSuite) TestSearchCirclesBeforeWorks(c *C) {
    // [TODO] stub, lower priority, but should be verified to work...
}