make all message() calls conform to verbose

lmweber / diffcyt

R package for differential discovery analyses in high-dimensional cytometry data

MIT License

19 stars 12 forks source link

make all message() calls conform to verbose #4

Closed markrobinsonuzh closed 5 years ago

markrobinsonuzh commented 5 years ago

Maybe this was intentional, but I always find it weird to send out message()s when verbose=FALSE. This PR makes it consistent.

If it is intentional, maybe you can changes the docs ("Whether to print status messages during each step of the pipeline.") to say what it actually does.

lmweber commented 5 years ago

Thanks, yes I think this was simply an oversight. I added a couple of edits and will merge the pull request into both release and devel on Bioconductor.

lmweber commented 5 years ago

Ok it is all merged and pushed to Bioconductor release and devel now. There was a mess with the version numbers because I hadn't yet pulled the updated version numbers from the Bioconductor 3.9 release last week, so I had to cherry-pick the commits across instead (and add new commits to fix the version numbers).