Replace secp256k1 with @noble/secp256k1

lnbc1QWFyb24 / lnmessage

Talk to Lightning nodes from the Browser

MIT License

22 stars 7 forks source link

Replace secp256k1 with @noble/secp256k1 #21

Closed im-adithya closed 1 year ago

im-adithya commented 1 year ago

Thanks for building this :heart:

Was thinking if we could replace the secp256k1 package with @noble/secp256k1, which claims to be faster and is very light.

It also has all the methods currently being used except for publicKeyVerify


ecdh             -> getSharedSecret
publicKeyCreate  -> getPublicKey
privateKeyVerify -> utils.isValidPrivateKey
publicKeyVerify  -> :/

lnbc1QWFyb24 commented 1 year ago

Hey @im-adithya yeah I believe this would be possible and might be worth doing. Feel free to open a PR that does this and I can review, otherwise I can try and get to this at some point.

lnbc1QWFyb24 commented 1 year ago

Completed in v0.2.0. Thanks @im-adithya for the PR!