lnbits / boltcards

Bolt Cards (NXP NTAG424) - LNbits extension
MIT License
14 stars 10 forks source link

Can't add card with 0.0.2 #14

Closed margatemarcel closed 1 year ago

margatemarcel commented 1 year ago

First time user trying to add first NFC card to boltcards extension v0.0.2.

Kept getting following error:

boltcard_error

Worked fine on legend (0.0.1 extension) and someone else's instance (also 0.0.1).

Finally figured out how to manually downgrade extension (by copying files manually) to 0.0.1 on my own instance and I can now add the UID.

So I can only assume that 0.0.2 has broken things.

talvasconcelos commented 1 year ago

Can't reproduce your error, just added a new card, on 0.0.2/main!

Can you describe the steps? What browser are you using?

We fixed the validation error on 0.0.2

margatemarcel commented 1 year ago

I have 10 new cards, and tried to add a couple of them. Each time, when I select the wallet, max/daily limits, add name and UID and click Create Card I get the above error (with 0.0.2).

But when I tried to add same UIDs on legend.lnbits.com (extension 0.0.1) it worked fine, first time.

When I manually downloaded 0.0.1 and unzipped/copied files (the only way I could find out how to downgrade to previous version) - I was able to add any of my cards without issue.

I tried using both Safari and Chrome on my Mac, and also using Safari on iOS (over 4G to ensure FQDN connection to my instance etc).

massmux commented 1 year ago

same error here with 0.0.2

saerdnaa commented 1 year ago

same error here. After updating to 0.0.2, when I try to add a card, this is the error

2023-08-22 14:42:34.55 | ERROR | RequestValidationError: 1 validation error for Request
query -> card_id
  field required (type=value_error.missing)
2023-08-22 14:42:34.55 | INFO | ip0 - "POST /boltcards/api/v1/cards HTTP/1.0" 400
massmux commented 1 year ago

I have 10 new cards, and tried to add a couple of them. Each time, when I select the wallet, max/daily limits, add name and UID and click Create Card I get the above error (with 0.0.2).

But when I tried to add same UIDs on legend.lnbits.com (extension 0.0.1) it worked fine, first time.

When I manually downloaded 0.0.1 and unzipped/copied files (the only way I could find out how to downgrade to previous version) - I was able to add any of my cards without issue.

I tried using both Safari and Chrome on my Mac, and also using Safari on iOS (over 4G to ensure FQDN connection to my instance etc).

pls provide the link of the previous working version that you tested. in order to install manually

margatemarcel commented 1 year ago

pls provide the link of the previous working version that you tested. in order to install manually

https://github.com/lnbits/boltcards/releases/tag/0.0.0.1

massmux commented 1 year ago

pls provide the link of the previous working version that you tested. in order to install manually

https://github.com/lnbits/boltcards/releases/tag/0.0.0.1

First time user trying to add first NFC card to boltcards extension v0.0.2.

Kept getting following error:

boltcard_error

Worked fine on legend (0.0.1 extension) and someone else's instance (also 0.0.1).

Finally figured out how to manually downgrade extension (by copying files manually) to 0.0.1 on my own instance and I can now add the UID.

So I can only assume that 0.0.2 has broken things.

to downgrade, did you uninstalled the previous one from the dashboard and then installed from the tar file?

margatemarcel commented 1 year ago

No, I manually replaced ~/lnbits/data/extensions/boltcards.zip and removed/replaced the files in ~/lnbits/lnbits/extensions/boltcards from the updated .zip file.

I couldn't find a cleaner way to get it working at this time (it still appears as 0.0.2, but works).

dni commented 1 year ago

we merged this: https://github.com/lnbits/boltcards/pull/15

and after we merge this i will release 0.0.3

it should be resolved with that

dni commented 1 year ago

boltcards 0.0.3 released it should fix this issue, can you try?

saerdnaa commented 1 year ago

Yes, it works fine for me. Thanks

dni commented 1 year ago

brilliant

massmux commented 1 year ago

boltcards 0.0.3 released it should fix this issue, can you try?

Great work! thanks!

margatemarcel commented 1 year ago

Confirmed working for me too - many thanks.