search

lnbits / conduct

A simple lightning nodes conductor, with a code.
https://pypi.org/project/conduct
MIT License
0 stars 1 forks source link

initial implementation: work in progress #1

Open eillarra opened 4 years ago

eillarra commented 4 years ago

The initial implementation will have the following wallets (we will be taking the code from LNbits as reference):

We need to decide what are the methods we will implement (no need to cover the whole LND API, for example) and what these methods will return.

Error handling and tests need to be contemplated.

21isenough commented 4 years ago

I'm a little bit on the fence here but I would tend to favor a broader way of handling errors with exceptions. More power to the developers and allowing applications to manage these as they see fit (viewing conductas a standalone piece of software with a wide range of applications).

eillarra commented 4 years ago

I'm a little bit on the fence here but I would tend to favor a broader way of handling errors with exceptions. More power to the developers and allowing applications to manage these as they see fit (viewing conductas a standalone piece of software with a wide range of applications).

Yes, I am leaning towards that too. Raise a meaningful exception, or return data, and let users decide how to handle these exceptions.

fiatjaf commented 4 years ago

Can we have invoices with description_hash? I need them for lnurl-pay stuff.