lnbits / lnurl

LNURL implementation for Python.
https://pypi.org/project/lnurl
MIT License
64 stars 19 forks source link

Include port in Url.base #5

Closed frennkie closed 4 years ago

frennkie commented 4 years ago

https://github.com/python-ln/lnurl/blob/6a6cedf29e24ff0c532735b37ec3e09cca9d2e9c/lnurl/types.py#L81

Is the port omitted intentionally? As far as I understand all of the following are valid URL, right?!

Should the base not always contain the port?

jogc commented 4 years ago

@eillarra ?

eillarra commented 4 years ago

Fixed on 1e803287766f004705abe6ba340ca96473f114af