search

lnbits / nostrnip5

MIT License
3 stars 3 forks source link

[BUG] Nostr NIP-5 extension Issues #11

Closed HamishMacEwan closed 1 month ago

HamishMacEwan commented 1 year ago

Describe the bug

  1. Paid Local Part registrations aren't being activated if paid for by a remote LNbits node:

e.g. from: image to image

And Success! Your username is now active at crazynoisybizarretown@nostriches.verifiableclaims.nz. Please add this to your nostr profile accordingly. If you ever need to rotate your keys, you can still keep your identity!

but crazynoisybizarretown (ID KkD479tGBVg9HZFaErbbRn) isn't active: image

But there is no such problem if paid from an account in the same usr.

  1. When using the active NIP-5 validation Failed to verify NIP05 identifier on server is the result.

https://nostriches.verifiableclaims.nz/.well-known/nostr.json?name=crazynoisybizarretown

Expected behavior

  1. That wherever the payment was made, if successful the NIP-05 would be active.
  2. That the NIP-05 would be accepted by Nostr clients.

Desktop (please complete the following information):

Additional context I would love a NIP-05 server validator.

talvasconcelos commented 1 year ago

I think this might be a listeners issue! Is the issue still present? Does it happen if you try a payment on a freshly booted lnbits?

dni commented 1 year ago

is this related to lnurlp extension? https://github.com/lnbits/lnurlp

motorina0 commented 2 months ago

Transferred issue this repo. The issue is fixed, but I will close it after the next release is out.

S7NC commented 2 months ago

Transferred issue this repo. The issue is fixed, but I will close it after the next release is out.

Just did a test of 2.6, issue still seems to persist, after payment the nip-05 is still active false

motorina0 commented 2 months ago

There might be an issue with extension upgrade. Can you please restart your LNbits instance.

I have re-tested and it works as expected.

Do you have any errors in the logs?

S7NC commented 2 months ago

i'll try a fresh instance, might be the upgrades, also thanks for these upgrades this extension is becoming serious 🔥

S7NC commented 2 months ago

Ran a fresh 12.10 copy, set with Alby wallet

2024-08-08 12:49:33.74 | INFO | 172.17.0.1:62910 - "GET /nostrnip5/api/v1/domain/kpEf4e3CfaAsCoE4hzpiAb/payments/cec017fbc8f6f748d21a07211f259d3abddb143a80ab91a492a0bf158b527774 HTTP/1.1" 200 2024-08-08 12:49:36.62 | DEBUG | Checking incoming pending payment cec017fbc8f6f748d21a07211f259d3abddb143a80ab91a492a0bf158b527774 2024-08-08 12:49:36.71 | DEBUG | Status: success 2024-08-08 12:49:36.72 | INFO | Marking 'in' cec017fbc8f6f748d21a07211f259d3abddb143a80ab91a492a0bf158b527774 as not pending anymore: success 2024-08-08 12:49:36.78 | INFO | 172.17.0.1:62910 - "GET /nostrnip5/api/v1/domain/kpEf4e3CfaAsCoE4hzpiAb/payments/cec017fbc8f6f748d21a07211f259d3abddb143a80ab91a492a0bf158b527774 HTTP/1.1" 200 2024-08-08 12:49:47.20 | INFO | 172.17.0.1:62914 - "GET /nostrnip5/ HTTP/1.1" 200 2024-08-08 12:49:47.36 | INFO | 172.17.0.1:62920 - "GET /nostrnip5/static/image/nostrnip5.png HTTP/1.1" 200 2024-08-08 12:49:47.38 | ERROR | Exception: No response returned. 2024-08-08 12:49:47.39 | ERROR | Exception in ASGI application

Seems to be fine but after payment they still remains false, could it depend on the funding source ? I'll try to look into it a bit better in the next few days

S7NC commented 1 month ago

Forgot to give an update but all works as expected, was just expecting a full list to appear on the nostr.json route but seems that going through the name query works fine. Great work !