Closed talvasconcelos closed 1 year ago
A relay can in theory have 100k+ accounts, out of which only a few hundreds are blocked or explicitly allowed.
@talvasconcelos Would the approach in this PR fetch all 100k+ all the time?
yes, and I see your point. i need to rethink this.
the get wasn't retrieving anything from the DB, though.
On Fri, Jul 14, 2023, 11:58 AM Vlad Stan @.***> wrote:
A relay can in theory have 100k+ accounts, out of which only a few hundreds are blocked or explicitly allowed.
@talvasconcelos https://github.com/talvasconcelos Would the approach in this PR fetch all 100k+ all the time?
— Reply to this email directly, view it on GitHub https://github.com/lnbits/nostr-relay-extension/pull/16#issuecomment-1635690296, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4F74TXGZUYCVJ4IYEKHHTXQEQ6NANCNFSM6AAAAAA2KEGXOY . You are receiving this because you were mentioned.Message ID: @.***>
@motorina0 filtering is working on testing. Can you please make a final review ?
Thank you! @talvasconcelos @motorina0
Instead of asking the DB for the accounts, we now call it once and filter client side! Filtering now works as expected.
@motorina0 , when toggling, in the account row, shouldn't the toggles be allowed OR blocked? and never the two at the same time? or is it that a user can be blocked for some time, if the OP whiches? If the later, PR is ready, if not I'll fix it also.
Closes #8