search

lnbits / satspay

Create onchain and LN charges
MIT License
8 stars 4 forks source link

Added amount to onchain QR #29

Closed cryptoteun closed 1 year ago

cryptoteun commented 1 year ago

Added amount to onchain QR, try to fix #28

cryptoteun commented 1 year ago

Not sure if this is the most elegant way. I copied the solution of the unifiedQR.

motorina0 commented 1 year ago

Although it is useful to have the amount in the QR code for onchain payments it might be the case that some wallets do not support BIP21. Therefore those wallets could not scan the QR code at all.

@talvasconcelos is the BIP21 QR code shown only if both onchain and LN payments are accepted?

cryptoteun commented 1 year ago

Did some additional testing. PR breaks some things, so I delete it. The BIP21 is indeed shown when Onchain only as well, so then for supporting wallets the amount is included.