lnbits / satspay

Create onchain and LN charges
MIT License
8 stars 4 forks source link

Fix lightning qr/copy value #35

Closed lightningcheckout closed 9 months ago

lightningcheckout commented 1 year ago

For example umbrell isn't handling the value of the QR and copy invoice button correctly due to the addition of 'lightning:' Shouldn't be needed I think, since when a user scans the QR they will most likely do it with a wallet already. Same applices for the copy invoice, then they will paste it in their preferred wallet.

motorina0 commented 9 months ago

The lighting: prefix can help a code reader identify which app to use.

https://github.com/lightning/bolts/blob/master/11-payment-encoding.md#encoding-overview

If a URI scheme is desired, the current recommendation is to either use 'lightning:' as a prefix before the BOLT-11 encoding (note: not 'lightning://'), or for fallback to Bitcoin payments, to use 'bitcoin:', as per BIP-21, with the key 'lightning' and the value equal to the BOLT-11 encoding.

Maybe this is an issue with umbrell.