search

lnbits / splitpayments

MIT License
13 stars 7 forks source link

Feature request: Forwarding notes #15

Open jurjendevries opened 8 months ago

jurjendevries commented 8 months ago

Hi,

Thank you for providing this extension. I am currently setting this up as proof of concept for a restaurant that is accepting Lightning already, but as a tip box for their staff. This so their staff will be orange pilled as well. It worked pretty well by creating a LNURLP for the splitted wallet, the only thing I wish for is that the original note given by original payment will be forwarded to the note in the destination wallets. It's okay for me to include the original note in the current given note 'Split payment: % for '

Thanks and keep up the good work.

DoktorShift commented 3 months ago

This could match my feature request. I will grow the root here.

Status Quo:

I reveive as an payment to my lnbits server an Order ID from an e-commerce shop plugin inside the extra field "comment". I want to forward that Order ID to the target wallet where the split also is going.

Right now, that Split payment extension generates a "memo" message out of the parameters "Alias" and "Split" which will be set in the Options where i creat the split payment. Thisd memo is forwarded alongside the splitpayment payment flow. I would prefer to see that the Order ID inside the extra field "comment" is selected.

You can see in the following screenshot the extra field "comment" which is not considered alongside the split payment to the target wallet:

issue_split

Inside the target wallet of the splitpayment the "memo" txt message Split payment: 99.5% for XY is displayed

My suggestion:

Some kind of check if extra field "comment" is true. If so, take that note instead of default memo.

Edit: I just got the information, that the Json with the extra field is only in lnbits db and is not part of the LN spec.

Someone know how to handle this issue so that I can forward my needs?