lnbits / withdraw

LNbits Withdraw Extension
MIT License
6 stars 10 forks source link

Redemption Periods for LNURL-Withdraw #15

Open cos-it-is opened 1 year ago

cos-it-is commented 1 year ago

Include the ability to set redemption periods for LNURL withdrawals.

Use case: To allow the purchase of gift vouchers through an ATM thermal printer. Insert FIAT, print gift voucher that has a pre-defined redemption period before expiry.

cos-it-is commented 1 year ago

Would be good set between 1 day and like 6 or 12 months. The user can take the risk on volatility or use stable sats solution.

dni commented 1 year ago

hm, i think just a date would do it

cos-it-is commented 1 year ago

hm, i think just a date would do it

By having a set date only it isn't relative to the time of issue. With regards to the ATM, the withdrawal is created sporadically so a set date would make the validity of an invoice created today one day less than one created tomorrow and so on. The validity period should begin on creation. e.g. print today and it is valid for one month. Print in 7 days time, and it is valid for 1 month from printing.

Unless you're referring to creating an invoice and setting a date? But using date format will require proper implementation of NTP in endpoint devices.

From a device use case perspective, a modification to lnurldevices so that a user can set redemption periods for their device on a day time frame would work better. But maybe that is a separate issue? (https://github.com/lnbits/lnurldevice/issues/21) A modification also to that extension?

dni commented 1 year ago

ok i'm convinced lets do relative times :)

2nd. yep lnurldevice is independent of this.