search

lnccbrown / HSSM

Development of HSSM package
Other
82 stars 11 forks source link

Decide if doing nothing before check? #500

Closed cpaniaguam closed 1 month ago

cpaniaguam commented 4 months ago

https://github.com/lnccbrown/HSSM/blob/2b8fadbd1098c54e449ba95dbec963eb7d5a4617/src/hssm/param.py#L101-L104

digicosmos86 commented 4 months ago

Not sure about this. The idea of _ensure_not_converted() is to freeze the entire class, so no further changes can be made. So this check should always happen before any computation is made

cpaniaguam commented 4 months ago

I see what you mean but if the check in L103 passes no computations will be made. That's why I thought of maybe inverting the order here.

digicosmos86 commented 1 month ago

Closing this. This is no longer issue after the Param refactor is introduced