search

lncm / docker-bitcoind

Flexible multi-arch (amd & amd64) Bitcoin Core Docker image
https://hub.docker.com/r/lncm/bitcoind
MIT License
102 stars 34 forks source link

Version 0.23 has been released #64

Closed Goro2030 closed 2 years ago

Goro2030 commented 2 years ago

Please do the needed quick changes to build 0.23 image :)

AaronDewes commented 2 years ago

Just FYI: the latest version is called 23.0, not 0.23

nolim1t commented 2 years ago

Will do thanks for the update

Goro2030 commented 2 years ago

Just FYI: the latest version is called 23.0, not 0.23

Absolutelly correct. It's just my mind getting used to the old numbering scheme :)

I'm building the dockerfile myself to test it ... is it just changing ARG VERSION, and also bumping ALPINE to latest?

# VERSION of Bitcoin Core to be build
#   NOTE: Unlike our other images this one is NOT prefixed with `v`,
#           as many things (like download URLs) use this form instead.
ARG VERSION=23.0

# CPU architecture to build binaries for
ARG ARCH

# Define default versions so that they don't have to be repeated throughout the file
ARG VER_ALPINE=3.15.4
Goro2030 commented 2 years ago

Just FYI: the latest version is called 23.0, not 0.23

Do you have a link to the "CHANGELOG" of 23.0? Can't find it...

Goro2030 commented 2 years ago

Looks like that for some reason, eventough v23.0 has been released 3 days ago in binary form, the source package is not at https://bitcoincore.org/bin/bitcoin-core-23.0

AaronDewes commented 2 years ago

Just FYI: the latest version is called 23.0, not 0.23

Do you have a link to the "CHANGELOG" of 23.0? Can't find it...

https://github.com/bitcoin-core/bitcoin-devwiki/wiki/23.0-Release-Notes-draft

It's not final yet

nolim1t commented 2 years ago

Its not released yet as the build scripts fail

nolim1t commented 2 years ago

Revisiting this issue.. Its now on bitcoincore.org

.. seems theres more signatures to be verified

Goro2030 commented 2 years ago

Is V23 in the new folder already compiling? If so, do you plan to push it to Docker hub, @nolim1t ?

nolim1t commented 2 years ago

Yep when all issues are resolved I'll make a release

nolim1t commented 2 years ago

Anyone is welcome to contribute though. I think @AaronDewes maybe also a maintainer of this project too or maybe another lncm repo.

nolim1t commented 2 years ago

Build looks fine.. There was issues with expired PGP keys and such (I'm using this list) .

Not to mention missing keys too that aren't in that list.

Damn bitcoin developers need to get their keys sorted out.

I commented out the key verifications but I don't like doing this

nolim1t commented 2 years ago

It's built with the above caveats

https://github.com/lncm/docker-bitcoind/issues/64#issuecomment-1113036821

Don't like removing things like that, however it is available now.

Goro2030 commented 2 years ago

Thanks @nolim1t , that was quick! I can use the new super functionality that the new version brings ... like, nothing basically :)