search

lncm / invoicer

Invoice generating service that lives on top of lnd.
https://hub.docker.com/r/lncm/invoicer
MIT License
8 stars 3 forks source link

Add currency conversion #36

Open meeDamian opened 5 years ago

meeDamian commented 5 years ago

Should we?

Or maybe just an extra endpoint returning exchange rates?

Or extra /fiatInvoice endpoint?

nolim1t commented 5 years ago

I don't think we should add fiat to it. The end game for bitcoin is to make fiat "irrelephant".

I think calling an API to get the rates will suffice for now. Should merchants not want to have too much expose (again not an issue now), they can all another API from an exchange of their choice and see what sort of rates they can get at the time.

meeDamian commented 5 years ago

Good point.

BUT, someone has to do it. Currently fronted does it, but given it might be useful to at least a few fronteds, it might make sense to have it handled by backend.

I agree it doesn't make sense to go out of our way to get it to work, but I know some free APIs and we can easily have an extra endpoint that supports at least a few currencies we care about.

Happy to discuss it further, however.