lncm / invoicer

Invoice generating service that lives on top of lnd.
https://hub.docker.com/r/lncm/invoicer
MIT License
8 stars 3 forks source link

Replace gin with echo #41

Open meeDamian opened 5 years ago

meeDamian commented 5 years ago

Seems smaller, and better https://github.com/labstack/echo

meeDamian commented 5 years ago

Some progress here: https://github.com/lncm/invoicer/tree/echo

Seems to work, but needs testing.

AnotherDroog commented 5 years ago

Gonna look and see how this compares

meeDamian commented 5 years ago

Hey don't bother, it's just an internals thing. echo just has less deps, is smaller, and APIs are designed in a slightly more sane way.

But there will be no API differences whatsoever for invoicer :).

Unless you want to dig out of your own curiosity, that is of course 😉.

AnotherDroog commented 5 years ago

Less deps is good in my book. I thought the console output might change?

meeDamian commented 5 years ago

I wasn't aware that anything relies on console output right now - is that the case? Or is there sth you'd like changed about console output? AFAIR, now after start all output goes to a log file.