lncm / invoicer

Invoice generating service that lives on top of lnd.
https://hub.docker.com/r/lncm/invoicer
MIT License
8 stars 3 forks source link

Mainly build process & artifacts #43

Closed meeDamian closed 5 years ago

meeDamian commented 5 years ago

This PR contains:

Note on determinism

This PR uses Docker stages to concurrently build invoicer for each supported platform, on two different operating systems: Alpine and Debian, and then uses a 3rd stage to fetch both and compare if output binaries are strictly identical. And only if they are the final stage is created.


This change is Reviewable

meeDamian commented 5 years ago

Since Travis doesn't seems to like Buildkit for whatever reason… I reckon the switch to Github Actions might get a little accelerated…

meeDamian commented 5 years ago

Alright, finished and awaiting review :). cc. @AnotherDroog @nolim1t

meeDamian commented 5 years ago

@noaho You might want to take a look too, as this PR is primarily a CI/Docker change.

Basically Travis gets replaced with Github Actions, and Dockerfile is expanded to build the same on different OSs to verify the output is identical later.

nolim1t commented 5 years ago

lgtm

meeDamian commented 5 years ago

Released as v0.6.0.

Built log here: https://github.com/lncm/invoicer/runs/224216015 Release: https://github.com/lncm/invoicer/releases/tag/v0.6.0 Docker Hub: https://hub.docker.com/r/lncm/invoicer/tags?page=1&ordering=last_updated