lncm / invoicer

Invoice generating service that lives on top of lnd.
https://hub.docker.com/r/lncm/invoicer
MIT License
8 stars 3 forks source link

Simplify setting arch for the final stage #49

Closed meeDamian closed 4 years ago

meeDamian commented 4 years ago

I think you could simplify that a lot with a build arg.

See:

It's one extra command in the build system to register QEMU and then a build arg to specify the architecture.

How sure are you that qemu is able to do that perfectly for every single arbitrary assembly instruction?

It's used for emulation by the Android SDK so I'd have to imagine it's pretty accurate but I really don't know.

Originally posted by @lukechilds in https://github.com/lncm/invoicer/pull/48

meeDamian commented 4 years ago

Done