search

lncm / noma

Noma - Bitcoin lightning node management CLI utility & Python API
https://lncm.io
Apache License 2.0
5 stars 2 forks source link

Install.sh message is misleading #62

Open ln2max opened 5 years ago

ln2max commented 5 years ago

https://github.com/lncm/noma/blob/638db12b23f5413e27d9bb9fcc97b749d9906c58/install.sh#L143

$ git clone https://github.com/lncm/noma.git
$ cd noma/
$ sudo ./install.sh
Sources not found, fetching from github...

"But I just got the sources!" Message should be something like Sources not found in /media, fetching from github...

nolim1t commented 5 years ago

I have to agree with that. I think ./install.sh should be worded a bit better or maybe make use of the current directory it is installed in?

nolim1t commented 5 years ago

For now the correct place it should really live in is /media/noma so you should ideally do a git clone https://github.com/lncm/noma.git /media

ln2max commented 5 years ago

Add that to the README.md?

nolim1t commented 5 years ago

Good idea or maybe change install.sh

thoughts @AnotherDroog ?

ln2max commented 5 years ago

The relevant changes to README.md ended up getting merged as part of PR #69 ... https://github.com/lncm/noma/commit/e35c9f5995b305f52e38ff5df66f8eec11661744

Leaving the issue open in case @AnotherDroog has thoughts or someone wants to change install.sh