lndk-org / lndk

MIT License
83 stars 21 forks source link

Bug: github actions, error when uploading to codecov #114

Closed orbitalturtle closed 4 months ago

orbitalturtle commented 4 months ago

Describe the bug

When executing the codecov github action we've recently been getting this output a lot:

[2024-05-30T20:19:50.808Z] ['info'] => Project root located at: /home/runner/work/lndk/lndk
[2024-05-30T20:19:50.809Z] ['info'] -> No token specified or token is empty
[2024-05-30T20:19:50.819Z] ['info'] Searching for coverage files...
[2024-05-30T20:19:50.907Z] ['info'] => Found 1 possible coverage files:
  lcov.info
[2024-05-30T20:19:50.907Z] ['info'] Processing /home/runner/work/lndk/lndk/lcov.info...
[2024-05-30T20:19:50.910Z] ['info'] Detected GitHub Actions as the CI provider.
[2024-05-30T20:19:51.139Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.6-uploader-0.7.3&token=*******&branch=max-width-fmt&build=9308650966&build_url=https%3A%2F%2Fgithub.com%2Flndk-org%2Flndk%2Factions%2Fruns%2F9308650966&commit=0cba7a2601ff8a06ef89666fbbde1e1015a85531&job=CI&pr=113&service=github-actions&slug=lndk-org%2Flndk&name=&tag=&flags=&parent=
[2024-05-30T20:19:51.441Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2625s.', code='throttled')}
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

Additional context

This doesn't seem to happen every time we run github actions, but a lot of the time.

orbitalturtle commented 4 months ago

It looks like we can fix this by upgrading codecov-action to v4: https://github.com/codecov/codecov-action?tab=readme-ov-file

"However, PRs made from forks to the upstream public repos will support tokenless"