lndk-org / lndk

MIT License
76 stars 19 forks source link

logs: add ldk sublogger #117

Closed mauricepoirrier closed 1 month ago

mauricepoirrier commented 1 month ago

This PR implements solution to #28:

I tried adding just the prefix ldk: {} but it didn't feel right.

Few examples

Current log 2024-06-10T19:02:45.197452-04:00 TRACE lndk::onion_messenger - Missing reply path when responding to Offers onion message with path_id None

Only prefix: 2024-06-10T19:02:45.197452-04:00 TRACE lndk::onion_messenger - ldk: Missing reply path when responding to Offers onion message with path_id None

With subsystem (this PR) 2024-06-10T19:20:58.794410-04:00 TRACE ldk - Missing reply path when responding to Offers onion message with path_id None

orbitalturtle commented 1 month ago

Thanks for the PR @mauricepoirrier! I'll give this a test run later this week.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (27df32b) to head (b341ace). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #117 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 1 1 Lines 77 77 ====================================== Misses 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mauricepoirrier commented 1 month ago

@orbitalturtle great, force pushed the update. Thanks for the review 🙌🏼