lndk-org / lndk

MIT License
76 stars 19 forks source link

offers: track active payments instead of offers #128

Closed orbitalturtle closed 3 weeks ago

orbitalturtle commented 1 month ago

Instead of tracking the offers we're paying, we move to instead track active payments by PaymentId through their lifecycle. This model is more intuitive. It makes it easier for us to track whether we've already received an invoice for the payment or not. As a byproduct, this change also allows us to pay the same offer multiple at once, which we didn't allow for before.

This change also includes some integration test refactoring so we can reuse certain functionality (establishing channels in a network and setting up lndk) across tests.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (23fe019) to head (1d48f29).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #128 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 1 1 Lines 96 96 ====================================== Misses 96 96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.