lndk-org / lndk

MIT License
83 stars 21 forks source link

Feature: More granular pay offer #129

Closed mauricepoirrier closed 3 months ago

mauricepoirrier commented 3 months ago

Should close #124

In this Pr:

Some details

  1. I serialized the invoice using Readable from LDK newest versions and then hex the bytes as decribed in this comment
  2. Another decision was to not use the interface from lnd and use the offer itself. This might be changed. Other implementations use the invoices as the parameter.

I didn't test as much I wanted but I'd like feedback first

mauricepoirrier commented 3 months ago

@mrfelton might wanna check this 👀

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (23fe019) to head (24fe6b4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 1 1 Lines 96 96 ====================================== Misses 96 96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mrfelton commented 3 months ago

Awesome. Any chance you could create a version that is rebased on top of https://github.com/lndk-org/lndk/pull/128? it would make testing a lot easier.

mauricepoirrier commented 3 months ago

Awesome. Any chance you could create a version that is rebased on top of #128? it would make testing a lot easier.

I'll try ;)

mauricepoirrier commented 3 months ago

closing, moved to #131