lndk-org / lndk

MIT License
84 stars 22 forks source link

Update CI actions and replace unmaintained actions #141

Closed dunxen closed 4 months ago

dunxen commented 4 months ago

This should get rid of a bunch of warnings in the actions logs related to node 16 as well, I believe.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (5535413) to head (8fc2c32). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #141 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 1 1 Lines 97 97 ====================================== Misses 97 97 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dunxen commented 4 months ago

So has dtolnay's project become the de facto alternative? I'm just curious if there's a splintering in the community over what to use.

Yeah I couldn't find a fork of the actions-rs org and it seems most are moving to dtolnay's action from PRs linked to this issue: https://github.com/actions-rs/toolchain/issues/216.

If rustup is available on the image we could also just manually install cargo stable.

orbitalturtle commented 4 months ago

Yeah I couldn't find a fork of the actions-rs org and it seems most are moving to dtolnay's action from PRs linked to this issue: https://github.com/actions-rs/toolchain/issues/216.

Ahh I see, also it looks like it's "used by" 28k projects according to the github repository home page and he kind of won me over a bit with this comment: https://www.reddit.com/r/rust/comments/vyx4oj/comment/ig54zv7/. The main problem people seem to have from scanning the comments is it doesn't support very complex features, which isn't a problem for us, so I'd be down to use it